feat: add aws.log.group.names attribute to LambdaResourceDetector
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garysassano
force-pushed
the
lambda-log-group
branch
from
18be1c9 to
aa63a14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
+ Coverage 54.3% 54.4% +0.1%
=======================================
Files 41 41
Lines 6227 6243 +16
=======================================
+ Hits 3384 3400 +16
Misses 2843 2843 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Dec 12, 2024
|
nit - changelog ? |
|
@lalitb What do you mean? Am I supposed to provide something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
aws.log.group.namesresource attribute toLambdaResourceDetectorusing theAWS_LAMBDA_LOG_GROUP_NAMEenvironment variable that is always available in Lambda runtimes.This follows the OpenTelemetry semantic convention for AWS Logs attributes.
The semantic convention specifies that
aws.log.group.namesshould be an array of strings to support cases like multi-container applications, though in AWS Lambda we'll only ever have a single log group.Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes